Skip to content

Conversation

@nepozs
Copy link
Contributor

@nepozs nepozs commented Nov 9, 2025

Update outdated versions MCP23017, MCP23008 datasheet
Update MCP23017, MCP23016, MCP23008 datasheet links to HTTPS

Description:

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable):

  • esphome/esphome#

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /components/index.rst when creating new documents for new components or cookbook.

New Component Images

If you are adding a new component to ESPHome, you can automatically generate a standardized black and white component name image for the documentation.

To generate a component image:

  1. Comment on this pull request with the following command, replacing COMPONENT_NAME with your component name in UPPER_CASE format with underscores (e.g., BME280, SHT3X, DALLAS_TEMP):

    @esphomebot generate image COMPONENT_NAME
    
  2. The ESPHome bot will respond with a downloadable ZIP file containing the SVG image.

  3. Extract the SVG file and place it in the images/ folder of this repository.

  4. Use the image in your component's index table entry in /components/index.rst.

Example: For a component called "DHT22 Temperature Sensor", use:

@esphomebot generate image DHT22

Update outdated MCP23017 datasheet
@esphome esphome bot added the current label Nov 9, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 9, 2025

Walkthrough

Updated three MCP230xx component datasheet links from HTTP to HTTPS (MCP23008, MCP23016, MCP23017). No content, functional, or API changes.

Changes

Cohort / File(s) Summary
Documentation URL updates
content/components/mcp230xx.md
Replaced three datasheet links (MCP23008, MCP23016, MCP23017) from http:// to https://; no other edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Review focus: verify each updated HTTPS URL resolves to the intended datasheet and confirm Markdown formatting.

Suggested reviewers

  • nagyrobi
  • DjordjeMandic

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description is related to the changeset. It mentions updating MCP23017, MCP23016, and MCP23008 datasheet links to HTTPS, which aligns with the actual changes in the mcp230xx.md file.
Title check ✅ Passed The title accurately describes the main change: updating the mcp230xx.md file with datasheet links converted to HTTPS, which matches the actual modifications in the changeset.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
content/components/mcp230xx.md (1)

22-22: Consider updating MCP23008 and MCP23016 datasheet links for consistency.

The MCP23017 datasheet link is now HTTPS with a modern path structure (line 134), while MCP23008 (line 22) and MCP23016 (line 81) still use HTTP with legacy paths. While this PR focuses on MCP23017 alone, consider whether the other two variants should also be updated for consistency in a follow-up change.

Also applies to: 81-81, 134-134

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ef7147 and ce68bee.

📒 Files selected for processing (1)
  • content/components/mcp230xx.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

  • Do not generate or add any sequence diagrams

Files:

  • content/components/mcp230xx.md
🧠 Learnings (1)
📓 Common learnings
Learnt from: jesserockz
Repo: esphome/esphome-docs PR: 4865
File: .github/workflows/needs-docs.yml:0-0
Timestamp: 2025-05-01T03:29:47.922Z
Learning: In the esphome-docs repository, the "current" label is automatically added by a bot to pull requests, making it a reliable indicator for the target branch.
Learnt from: CR
Repo: esphome/esphome-docs PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-24T00:13:13.459Z
Learning: Open pull requests against the correct base branch: use `current` for documentation-only revisions and `next` for changes tied to new features in esphome/esphome
🔇 Additional comments (1)
content/components/mcp230xx.md (1)

134-134: Based on the verification results:

No issues found—URL is valid, current, and resolves to the correct datasheet.

The new URL resolves to DS20001952D (2022 revision), which is the current version of the MCP23017 datasheet. The HTTP/2 200 response and valid PDF content type confirm the link is functional. The HTTPS upgrade and updated path structure represent a legitimate modernization of Microchip's documentation infrastructure.

@netlify
Copy link

netlify bot commented Nov 9, 2025

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 4faeccc
🔍 Latest deploy log https://app.netlify.com/projects/esphome/deploys/6911cd12b938400008d65b1a
😎 Deploy Preview https://deploy-preview-5581--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Updated also datasheets of current revision MCP23008 (important differences) and MCP23016 (new link only, document revision is the same)
@nepozs nepozs changed the title Update mcp230xx.md Update mcp230xx.md - update datasheets to current versions aln links to HTTPS Nov 10, 2025
@nepozs nepozs changed the title Update mcp230xx.md - update datasheets to current versions aln links to HTTPS Update mcp230xx.md - update datasheets to current versions and links to HTTPS Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant