-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update mcp230xx.md - update datasheets to current versions and links to HTTPS #5581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
Update outdated MCP23017 datasheet
WalkthroughUpdated three MCP230xx component datasheet links from HTTP to HTTPS (MCP23008, MCP23016, MCP23017). No content, functional, or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
content/components/mcp230xx.md (1)
22-22: Consider updating MCP23008 and MCP23016 datasheet links for consistency.The MCP23017 datasheet link is now HTTPS with a modern path structure (line 134), while MCP23008 (line 22) and MCP23016 (line 81) still use HTTP with legacy paths. While this PR focuses on MCP23017 alone, consider whether the other two variants should also be updated for consistency in a follow-up change.
Also applies to: 81-81, 134-134
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
content/components/mcp230xx.md(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**
⚙️ CodeRabbit configuration file
- Do not generate or add any sequence diagrams
Files:
content/components/mcp230xx.md
🧠 Learnings (1)
📓 Common learnings
Learnt from: jesserockz
Repo: esphome/esphome-docs PR: 4865
File: .github/workflows/needs-docs.yml:0-0
Timestamp: 2025-05-01T03:29:47.922Z
Learning: In the esphome-docs repository, the "current" label is automatically added by a bot to pull requests, making it a reliable indicator for the target branch.
Learnt from: CR
Repo: esphome/esphome-docs PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-08-24T00:13:13.459Z
Learning: Open pull requests against the correct base branch: use `current` for documentation-only revisions and `next` for changes tied to new features in esphome/esphome
🔇 Additional comments (1)
content/components/mcp230xx.md (1)
134-134: Based on the verification results:No issues found—URL is valid, current, and resolves to the correct datasheet.
The new URL resolves to DS20001952D (2022 revision), which is the current version of the MCP23017 datasheet. The HTTP/2 200 response and valid PDF content type confirm the link is functional. The HTTPS upgrade and updated path structure represent a legitimate modernization of Microchip's documentation infrastructure.
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Updated also datasheets of current revision MCP23008 (important differences) and MCP23016 (new link only, document revision is the same)
Update outdated versions MCP23017, MCP23008 datasheet
Update MCP23017, MCP23016, MCP23008 datasheet links to HTTPS
Description:
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable):
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rstwhen creating new documents for new components or cookbook.New Component Images
If you are adding a new component to ESPHome, you can automatically generate a standardized black and white component name image for the documentation.
To generate a component image:
Comment on this pull request with the following command, replacing
COMPONENT_NAMEwith your component name in UPPER_CASE format with underscores (e.g.,BME280,SHT3X,DALLAS_TEMP):The ESPHome bot will respond with a downloadable ZIP file containing the SVG image.
Extract the SVG file and place it in the
images/folder of this repository.Use the image in your component's index table entry in
/components/index.rst.Example: For a component called "DHT22 Temperature Sensor", use: